Fix(5512): Tertiary menu list structure - avoid nested <li>#5527
Draft
accesswatch wants to merge 7 commits intomainfrom
Draft
Fix(5512): Tertiary menu list structure - avoid nested <li>#5527accesswatch wants to merge 7 commits intomainfrom
accesswatch wants to merge 7 commits intomainfrom
Conversation
Both split-toggle buttons previously used {{ item.title }} as their
visually-hidden text, making them indistinguishable from the adjacent
link for screen reader users (WCAG 4.1.2 Name, Role, Value).
- Append ', expand submenu' (translatable) to the visually-hidden text
on both the level-0 and level-1 split-toggle buttons so they
announce distinctly from the adjacent link (e.g. "People, expand
submenu, button" vs "People, link").
- Remove data-bs-auto-close="outside" from the level-1 collapse
trigger button; that attribute is a Bootstrap Dropdown option only
and has no effect on a data-bs-toggle="collapse" element.
Both the level-0 and level-1 split-toggle buttons were using
{{ item.title }} as their visually-hidden text, making them
indistinguishable from the adjacent link for screen reader users
(e.g. both announced as "People, link" and "People, button").
Changes:
- Add ', expand submenu' suffix (translatable) to the visually-hidden
span on both split-toggle buttons so they announce distinctly from
their sibling links (e.g. "People, expand submenu, button").
- Remove the ineffective data-bs-auto-close="outside" attribute from
the level-1 collapse button; that option only applies to
data-bs-toggle="dropdown", not data-bs-toggle="collapse".
Fixes #5511
…toggle text - Use single translatable string with @title placeholder instead of concatenating item.title with separately-translated suffix (i18n) - Make level 1 collapse toggle label state-aware: 'Collapse submenu' when expanded, 'Expand submenu' when collapsed (WCAG 4.1.2) - Level 0 dropdown toggle keeps 'Expand' since aria-expanded starts false and Bootstrap JS manages runtime state Resolves Copilot review comments on PR #5517
…n submenu labels" This reverts commit 76510e1.
…bmenu accessible name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5512 — Why: sites running Quickstart 3.2.0 with AZ Navbar saw HTML validation errors caused by nested
What this change does:
<li>pattern at the tertiary menu level so the menu renders valid HTML.Submenu for @title).Impact:
<ul>/<ol>direct-children` validation errors attributed to the navbar.How to test:
<ul>/<ol>error is gone.Notes: